Fix#2140: Fix username's cutoff in Home Page

[prayutsu]

Explanation

Fixes #2140:
If the username is too long then the username is displayed in the next line.

Short Names on WSVGA Tablet (Screen size - 7.00'')-

Before	After

Long Names on WSVGA Tablet (Screen size - 7.00'')-

Before	After

Short Names on QVGA Phone (Screen size - 3.20'')-

Before	After

Long Names on QVGA Phone (Screen size - 3.20'')-

Before	After

Newly Added Test cases passing on Espresso -

Newly Added Test cases passing on Robolectric -

Newly Added Test cases failing on Espresso(before making changes) -

Newly Added Test cases passing on Robolectric(before making changes) -

Fixed failed tests of other files -

ProfileChooserFragmentTest on ESPRESSO -

ProfileEditActivityTest on ESPRESSO -

ProfileEditActivityTest on Robolectric -

ProfileChooserFragmentTest on Robolectric -

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[anandwana001]

Also, test cases are need to test the fix.

[anandwana001]

Thanks @prayutsu
For orange line thing, I think the earlier. pr which is closed now for this issue has a reference on how the orange line should be aligned.

[Arjupta]

@prayutsu can I know what is the problem with the orange line, I think it is correct if it shown like this, as the username expands

[prayutsu]

Also, test cases are need to test the fix.

Yes, I'll be introducing test cases once we finalize the implementaton

[prayutsu]

@prayutsu can I know what is the problem with the orange line, I think it is correct if it shown like this, as the username expands

@Arjupta Actually, earlier the orange lie was below the salutation and its width matched the salutation. See this for refernce

[prayutsu]

According to this comment, we always want the orange line aligned to be left and below the salutation or username.
@mschanteltc @Arjupta @rt4914 @anandwana001 What should be the ideal width of the orange line?

[Arjupta]

According to this comment, we always want the orange line aligned to be left and below the salutation or username.
@mschanteltc @Arjupta @rt4914 @anandwana001 What should be the ideal width of the orange line?

I think the orange line must be having 40% of screen width , its just good to view. You can achieve this by using constraint percent. like this-

    android:layout_width="0dp"
    android:layout_height="wrap_content"
    android:layout_constraintWidth_percent="0.4"

[prayutsu]

@Arjupta Even I had the same thought to make the width of the line about 50%. But we also have another option to keep it as wide as the flexboxlayout
@mschanteltc @rt4914 @anandwana001 WDYT?

[mschanteltc]

@Arjupta Even I had the same thought to make the width of the line about 50%. But we also have another option to keep it as wide as the flexboxlayout
@mschanteltc @rt4914 @anandwana001 WDYT?

Is it possible to make the width of the orange line equal to the width of the greeting? I understand that the greeting may vary, so this would mean that the width would change depending on the time of the day.

If not possible, then let's make the width 172 dp just like it is in the mock.

[prayutsu]

I did some research but couldn't figure out any way to dynamically change the width of the line according to the greeting's width because they are not siblings.
@BenHenning Could you help us here?

[rt4914]

@prayutsu Have a look at this https://github.com/oppia/oppia-android/pull/2186/files in which the author has used two separate profile_name_text_views to handle the required functionality.

[prayutsu]

Thanks, @rt4914
Actually, I already took a look at the previous PR, and there I saw this comment by Ben.
So, I dropped the idea of using two textviews.

[anandwana001]

as Rajat and Arjun keeping update in this PR, unassigning myself.

[prayutsu]

@rt4914 I have enabled Reformat Code on committing, so it has automatically fixed some lint errors that were changed in the Binding Adapter commit, so it is okay, or do I need to revert these?

[rt4914]

@rt4914 I have enabled Reformat Code on committing, so it has automatically fixed some lint errors that were changed in the Binding Adapter commit, so it is okay, or do I need to revert these?

You can keep these changes and at the same time I suggest merging with latest develop too. Keeping your branch up-to-date is a nice practice.

[prayutsu]

@rt4914 I have enabled Reformat Code on committing, so it has automatically fixed some lint errors that were changed in the Binding Adapter commit, so it is okay, or do I need to revert these?

You can keep these changes and at the same time I suggest merging with latest develop too. Keeping your branch up-to-date is a nice practice.

Done, thanks

[prayutsu]

@rt4914 PTAL

[prayutsu]

Screenshots updated in PR description.

[anandwana001]

nit changes

[prayutsu]

PTAL

[anandwana001]

Left nit changes.

Find 2 issues, @rt4914 are there any issues filed for this?

Correct one

Incorrect

[anandwana001]

LGTM

[rt4914]

Left nit changes.

Find 2 issues, @rt4914 are there any issues filed for this?

Correct one

Incorrect

Just filed. #2529

[rt4914]

LGTM, Thanks.