Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and fix Profile Name across all screens #2529

Closed
rt4914 opened this issue Jan 21, 2021 · 2 comments · Fixed by #2556
Closed

Check and fix Profile Name across all screens #2529

rt4914 opened this issue Jan 21, 2021 · 2 comments · Fixed by #2556
Assignees
@khushal1707
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 21, 2021

Profile Name is shown in below mentioned screens and we should make sure that a name with maximum characters is clearly visible.

  • Profile Chooser Screen
  • Navigation Drawer Header
  • Home Screen Salutaion
  • Profile Progress
  • Profile List (in Admin Controls)
  • Profile View (in Admin Controls)

These needs to be tested and fixed on mobile-landscape, mobile-portrait, tablet-landscape and tablet-portrait.
@rt4914 rt4914 added this to the Beta milestone Jan 21, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Type: Improvement labels Jan 21, 2021
@rt4914 rt4914 mentioned this issue Jan 21, 2021
Merged
8 tasks
@khushal1707
Copy link
Contributor

I like to work on this issue, but in most of the screens name with max character length is correctly visible. The only place where I encounter problem is Profile View (in Admin Controls) with mobile-portrait, correct me if I'm wrong.

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 21, 2021

I like to work on this issue, but in most of the screens name with max character length is correctly visible. The only place where I encounter problem is Profile View (in Admin Controls) with mobile-portrait, correct me if I'm wrong.

You might be correct. Once you PR is out I will check this on all screens and see if we can improve further. Thanks.

@khushal1707 khushal1707 mentioned this issue Jan 24, 2021
Merged
8 tasks
This was referenced Jan 28, 2021
Closed
Closed
rt4914 pushed a commit that referenced this issue Feb 3, 2021
@khushal1707
Fix #2529: Fix username's cutoff in Various screens (#2556)
9524453 
* Fix#2529: Fix username's cutoff in Various screens

* Requested changes

* Changes in profile list's profile view

* Changes in Profile Chooser screen reverted

* Requested Changes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khushal1707 khushal1707

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2529: Fix username's cutoff in Various screens khushal1707/oppia-android
3 participants
@rt4914 @BenHenning @khushal1707