Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1824 : Full UI: Tablet: StoryActivity Landscape + Portrait #1835

Conversation

prayutsu
Copy link
Contributor

@prayutsu prayutsu commented Sep 10, 2020

Explanation

Fixes part of #1824
Added layout files for tablet

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@prayutsu
Copy link
Contributor Author

I guess it matches nicely with the mock design.

@prayutsu
Copy link
Contributor Author

@rt4914 PTAL

@rt4914
Copy link
Contributor

rt4914 commented Sep 15, 2020

@prayutsu I think you have added incorrect screenshot. Can you please fix that? Thanks.

@rt4914
Copy link
Contributor

rt4914 commented Sep 15, 2020

I am actually not able to understand which UI you are following, because if I run this, I get following UI for StoryActivity.
Screenshot_1600155612
Screenshot_1600155616

But instead we have to implement a UI similar to this: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/d70a3ade-826a-4ac6-95e6-907a24d7b896/

@rt4914 rt4914 removed their assignment Sep 15, 2020
@prayutsu
Copy link
Contributor Author

@prayutsu I think you have added incorrect screenshot. Can you please fix that? Thanks.

I'll correct it.

@prayutsu
Copy link
Contributor Author

@rt4914 A sample ss, please review it and suggest changes.

Screenshot_1600177725

Currently "0 of 2 chapters completed" is in left, but I think when we get that progressBar thing, it should look fine

@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Sep 15, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Now you can work on the exact UI part.

@rt4914 rt4914 merged commit 918a59d into oppia:develop Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants