Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi: Tablet: StoryActivity Landscape + Portrait #1824

Closed
1 of 3 tasks
rt4914 opened this issue Sep 8, 2020 · 2 comments · Fixed by #2993 or #3863
Closed
1 of 3 tasks

Lowfi: Tablet: StoryActivity Landscape + Portrait #1824

rt4914 opened this issue Sep 8, 2020 · 2 comments · Fixed by #2993 or #3863
Assignees
@viktoriias
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Sep 8, 2020 •
edited
Loading

This issue is tracking the full low-fi work of StoryActivity Tablet (Landscape + Portrait)

Mock: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/64ef596d-f0ee-48fe-afc2-2ae40367e382/
https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/d70a3ade-826a-4ac6-95e6-907a24d7b896/

Major work items:

  • Vertical dash line with progress
  • Inactive card - lock/blur effect.
  • RTL Supportive
    Note : Please test UI for RTL support, prior to merging this fix.
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Sep 8, 2020
@rt4914 rt4914 added this to the Beta milestone Sep 8, 2020
This was referenced Sep 10, 2020
Merged
Closed
@prayutsu prayutsu assigned rt4914 and unassigned prayutsu Oct 16, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 19, 2020

@prayutsu Thanks. I will refer to your PRs whenever I work on it.

@rt4914 rt4914 changed the title Full UI: Tablet: StoryActivity Landscape + Portrait Lowfi: Tablet: StoryActivity Landscape + Portrait Mar 23, 2021
@rt4914 rt4914 mentioned this issue Mar 23, 2021
Merged
8 tasks
rt4914 added a commit that referenced this issue Apr 8, 2021
@rt4914
Fix #1824: Lowfi story activity tablet (#2993)
4ea6027 
* Basic UI setup

* UI final

* Added test cases

* Nit fix

* Nit fix

* Nit fixes

* Added VerticalDashedLineView to bazel

* Resolved deprecated line

* Added nit change

* Changed place in Build.bazel

* Nit fix

* Suggested by Abhay

* Nit changes as suggested by Ben.

* Removed unused variable

* Updated usage of canvas and passing tests

* Formatting fixes

* Nit fix

* Added ImageViewBindingAdapters

* Shifted StoryActivity tests

* Nit spacing fix

* Nit changes

Co-authored-by: Rajat Talesra <[email protected]>
rt4914 added a commit that referenced this issue Apr 9, 2021
@rt4914
Revert "Fix #1824: Lowfi story activity tablet (#2993)"
aa15ddd 
This reverts commit 4ea6027.
BenHenning pushed a commit that referenced this issue Apr 9, 2021
@rt4914
Revert "Fix #1824: Lowfi story activity tablet (#2993)" (#3063)
9135499 
This reverts commit 4ea6027.
@rt4914 rt4914 reopened this Apr 9, 2021
@rt4914 rt4914 mentioned this issue Apr 9, 2021
Closed
8 tasks
@rt4914 rt4914 mentioned this issue May 6, 2021
Closed
@veena14cs
Copy link
Contributor

veena14cs commented Jul 6, 2021 •
edited
Loading

Note : Please test UI for RTL support, prior to merging this fix.

@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 12, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta (Features & Tasks) in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to Low-fi & High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 assigned viktoriias and unassigned rt4914 Sep 4, 2021
@viktoriias viktoriias mentioned this issue Oct 5, 2021
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Oct 22, 2021
BenHenning added a commit that referenced this issue Oct 22, 2021
@viktoriias @Viktoriia-Lozova @BenHenning
Fix part of #1824: Add chapter dash line (#3863)
a0769cc 
* Patch.

* lint

* lint

* lint

* Add intents

* Update app/src/main/java/org/oppia/android/app/customview/VerticalDashedLineView.kt

Co-authored-by: Ben Henning <[email protected]>

* Add intents

* Move non-overloaded method separately.

* lint

* Testing changes

* Add PlatformParameterSingletonModule

* Add BUILD.bazel file.

* Darken thicken grey circle.

* Update test

* Update test

* hifi

* Updates.

* Updates

* genrule

* genrule

* genrule

* genrule

* genrule

* genrule

* genrule

* genrule

* genrule

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/BUILD.bazel

Co-authored-by: Ben Henning <[email protected]>

* genrule

* genrule

* Add test_deps

* Add visibility

* Alphabetize

* Dimens refactor.

* Add more test targets

* Add more test targets

* Add another genrule

* lint

* Lint

* Lint

* Lint

Co-authored-by: viktoriia <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoriias viktoriias

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
6 participants
@rt4914 @viktoriias @BenHenning @veena14cs @nikitamarysolomanpvt @prayutsu