Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ProfileResetPinFragment #3968

Closed
yash10019coder opened this issue Oct 25, 2021 · 0 comments · Fixed by #4011
Closed

Introduce ProfileResetPinFragment #3968

yash10019coder opened this issue Oct 25, 2021 · 0 comments · Fixed by #4011
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@yash10019coder
Copy link
Contributor

Creating a ProfileResetPinFragment in the profile folder of the app module so that we can utilize the big tablet screen size by opening the fragment in a navhost fragment
This issue is a sub-issue of #3241

@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Nov 22, 2021
@rt4914 rt4914 added this to the Beta milestone Nov 22, 2021
@rt4914 rt4914 moved this from Needs Triage to [Beta] Low-fi & High-fi in CLAM Team (deprecated -- please use new board) Nov 22, 2021
CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Dec 17, 2021
BenHenning added a commit that referenced this issue Dec 17, 2021
* initial commit

* added imports in lexicographic order

* nit fixes.

* nit fixes.

* removed ProfileResetPinFragment.kt from test_file_exemptions.textproto

* added tests for ProfileResetPinFragmentTest.kt

* reformatted the code.

* added ProfileMangagementController in constructor injection
fixed the bug fixes for the failing tests
renamed all of the tests.

* reformatted the code.

* removed unused import.

* removed all the files for the settings/profile package from kdoc_validity_exemptions.textproto.

* added kdocs for all the files in the package settings/profile in app module.

* nit fixes for Kdoc comments and optimized imports in ProfileReset files.

* added imports in lexicographic order.

* nit fixes.

* nit fixes.

* nit fixes.

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivity.kt

Co-authored-by: Ben Henning <[email protected]>

* added the EOF for the required files.

* fixed kdocs in all viewmodels in settings/profile.

* fixed Kdocs for intents.

* nit fixes for intents.

* fixed typo for reference.

* fixed Kdocs for the methods.

* line wrapped the comment in ProfileEditFragmentPresenter.kt

* nit fixes.

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinViewModel.kt

Co-authored-by: Ben Henning <[email protected]>

* reformatted the multiline kdoc.

* Update app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

Co-authored-by: Ben Henning <[email protected]>

Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment