Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hi-Fi Profile List Tablet #3241

Open
4 tasks
anandwana001 opened this issue May 24, 2021 · 7 comments
Open
4 tasks

Hi-Fi Profile List Tablet #3241

anandwana001 opened this issue May 24, 2021 · 7 comments
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n... User team

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented May 24, 2021 •
edited by rt4914
Loading

Mobile - https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/ddc3dadf-10e4-45f6-aeea-eb8a330e00ff/

Tablet - https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/92134768-c62c-44f8-bbad-8429ce6e3ea0/

Follow this guide: https://github.com/oppia/oppia-android/wiki/Working-on-UI

Checklist

  • Implement rename screen inside a fragment
  • Implement reset-pin screen inside a fragment
  • Implement edit profile screen inside a fragment
  • Use above fragments such that in mobile view they are nested under their own activity and in tablet view the fragments are directly getting used and displayed on right side of AdministratorControlsActivity.
@anandwana001 anandwana001 changed the title Hi-Fi Profile List Hi-Fi Profile List Tablet May 24, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@yash10019coder
Copy link
Contributor

@anandwana001 facing some weird bug unable to create a new profile in tablet
image

@anandwana001
Copy link
Contributor Author

Could you please post the error from the log?

@yash10019coder
Copy link
Contributor

Now it's okay @anandwana001 I rebuilded the app and also updated my develop

@yash10019coder yash10019coder mentioned this issue Oct 12, 2021
Closed
@yash10019coder yash10019coder mentioned this issue Oct 25, 2021
Closed
@yash10019coder
Copy link
Contributor

Hi @anandwana001 @rt4914 Sometimes I'm unable to view the illustrations, this happens.
Thanks
image

@yash10019coder
Copy link
Contributor

Hi @anandwana001 can you please make the issue editable by contributors so that I can mark on the completed items in the checklist.
Thanks

@anandwana001
Copy link
Contributor Author

@yash10019coder This is just to keep the double-check process if in case the item is completed or not.
You can comment in an issue that which Item from the Issue list is completed and the issue author can mark it as completed.

@yash10019coder yash10019coder mentioned this issue Dec 9, 2021
Closed
This was referenced Dec 17, 2021
Closed
Merged
@yash10019coder
Copy link
Contributor

  1. Created and implemented ProfileRenameFragment for opening in its nested activities in mobile PR Issue
  2. Created and implemented ProfileResetPinFragment for opening in its nested activities in mobile PR Issue
  3. Implemented ProfileEditFragment to open at right side in multipane tablet mode and openi in their own nested activities in mobile PR Issue.

Tasks left is only to implement ProfileRenamePInFragment and ProfileResetPinFragment in tablet mode.

@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@Broppia Broppia added this to To do in User team via automation Jul 29, 2022
@BenHenning BenHenning added issue_type_enhancement Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 15, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. good first issue This item is good for new contributors to make their pull request. labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
CLAM Team (deprecated -- please use n...
[Beta] Low-fi & High-fi
User team
To do
Milestone
No milestone
Development

No branches or pull requests
6 participants
@seanlip @BenHenning @anandwana001 @adhiamboperes @yash10019coder @Broppia