Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL Exempted file fixes #3775

Closed
4 tasks done
viktoriias opened this issue Sep 10, 2021 · 0 comments
Closed
4 tasks done

RTL Exempted file fixes #3775

viktoriias opened this issue Sep 10, 2021 · 0 comments
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@viktoriias
Copy link
Contributor

viktoriias commented Sep 10, 2021 •
edited
Loading

file_content_validation_checks.textproto contains regex pattern checks to spot prohibited content. Some files are listed as exemplted_file_name because they contain prohibited elements . This is a tracking issue to fix exempted files that violate RTL rules. We should change those attributes to make it RTL compatible. For example, in add_profile_activity.xml: replace layout_constraintRight_toRightOf with layout_constraintEnd_toEndOf

Files to be updated:

RTL guidelines: https://github.com/oppia/oppia-android/wiki/RTL-Guidelines

Please add screenshots when creating a PR with both LTR and RTL views on mobile + tablet.
@viktoriias viktoriias added Type: Bug good first issue This item is good for new contributors to make their pull request. labels Sep 10, 2021
@viktoriias viktoriias mentioned this issue Sep 10, 2021
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Sep 16, 2021
@viktoriias @Viktoriia-Lozova
Fix part of #3775: RTL Exempted file fixes (#3776)
000dfd9 
* Change barrierDirection in topic_practice_subtopic files.

* Change barrierDirection in topic_practice_subtopic files.

* Change barrierDirection in topic_practice_subtopic files.

* Add back add_profile_activity.

* Remove empty space.

Co-authored-by: viktoriia <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viktoriias @BenHenning