Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL Exempted file] Fix styles.xml #3809

Closed
viktoriias opened this issue Sep 16, 2021 · 2 comments · Fixed by #3941
Closed

[RTL Exempted file] Fix styles.xml #3809

viktoriias opened this issue Sep 16, 2021 · 2 comments · Fixed by #3941
Assignees
@bkaur-bkj
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@viktoriias
Copy link
Contributor

file_content_validation_checks.textproto contains regex pattern checks to spot prohibited content. Some files are listed as exempted_file_name because they contain prohibited elements . This is a tracking issue to fix styles.xml exempted file and make it RTL compatible.

This Sample PR can be used as an example.

RTL guidelines: https://github.com/oppia/oppia-android/wiki/RTL-Guidelines

Please add screenshots when creating a PR with both LTR and RTL views on mobile + tablet.
@viktoriias viktoriias added Type: Bug good first issue This item is good for new contributors to make their pull request. labels Sep 16, 2021
@viktoriias viktoriias mentioned this issue Sep 16, 2021
Closed
4 tasks
@rt4914 rt4914 added this to the Backlog milestone Sep 24, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Sep 24, 2021
@rt4914 rt4914 moved this from Needs Triage to [Alpha MR3] RTL in CLAM Team (deprecated -- please use new board) Sep 24, 2021
@rawlin
Copy link
Contributor

rawlin commented Oct 4, 2021

Could you assign me this issue please

@viktoriias
Copy link
Contributor Author

@rawlin Any updates in this?

@bkaur-bkj bkaur-bkj self-assigned this Oct 16, 2021
@bkaur-bkj bkaur-bkj mentioned this issue Oct 16, 2021
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from [Alpha MR3] RTL to Closed Oct 19, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkaur-bkj bkaur-bkj

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Styles xml Fixes #3809 bkaur-bkj/oppia-android
5 participants
@rt4914 @viktoriias @BenHenning @rawlin @bkaur-bkj