Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Structure: Topic overview tab fragment [Blocked: #135] #136

Closed
BenHenning opened this issue Sep 19, 2019 · 2 comments
Closed

UI Structure: Topic overview tab fragment [Blocked: #135] #136

BenHenning opened this issue Sep 19, 2019 · 2 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@BenHenning
Copy link
Sponsor Member

This is tracking introducing the UI structure for the topic overview tab.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 19, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #118 and #135 (since the topic activity and fragment need to be introduced before this tab can be filled out).

@BenHenning BenHenning mentioned this issue Sep 19, 2019
Closed
5 tasks
@BenHenning BenHenning changed the title UI Structure: Topic overview tab fragment [Blocked: #118, #135] UI Structure: Topic overview tab fragment [Blocked: #135] Sep 30, 2019
rt4914 added a commit that referenced this issue Oct 24, 2019
@rt4914
Fix part of #136: Topic overview low fi part 1 (without Topic Downloa…
1a391ed 
…d) (#233)

* XML structure

* XML to ViewModel

* Topic Image 1

* Test case

* ViewModel to ObservableViewModel

* Merge conflicts

* Nit changes

* Updated ImageBinding implementation

* Added test-cases

* Revert some changes

* Nit change

* Nit changes

* Optimised strings
@rt4914
Copy link
Contributor

rt4914 commented Oct 24, 2019

@BenHenning PR #233 had title "Fix part of ..." because of introduced of topic-download functionality in subsequent PRs. So I think this issue has been resolved (except the topic-download functionality), should we close this issue?

@rt4914 rt4914 closed this as completed Oct 29, 2019
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @nikitamarysolomanpvt