UI Structure: Topic activity/fragment #135
Assignees
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Milestone
Comments
BenHenning
added
Type: Improvement
Priority: Essential
BenHenning
changed the title
|
This is blocked on #118 since the UI structure can't be built until there's a domain interface to consume. |
BenHenning
changed the title
This was referenced Sep 19, 2019
BenHenning
changed the title
rt4914
added a commit
that referenced
this issue
Sep 30, 2019
* Introduce TopicActivity/Fragment * Javadoc and nit changes * Javadoc and nit changes * Javadoc and nit changes * Topic tab base files * Javadoc for tabs * Renaming variables * Resolved all nit changes * Topic test cases and some nit changes * Final nit changes
|
@nikitamarysolomanpvt This issues needs multiple fragments which I have already in #192 . You can now find that in develop too. For now, you just have to create 4 tabs which changes those fragments as desired. Also, check email from Chantel, she has provided those tabs icons in one of her recent emails. |
I think she forgot to keep me in loop i never got any mails from Chantel. |
6 tasks
6 tasks
6 tasks
Okay |
6 tasks
6 tasks
nikitamarysolomanpvt
added a commit
that referenced
this issue
Nov 6, 2019
* multiple tabs * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * cust_args * test cases,multiple tabs will getting topic id from home Merge branch 'develop' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt # domain/src/main/java/org/oppia/domain/exploration/ExplorationRetriever.kt * nit * nit * nit * nit * nit * separate test cases for all four tabs * nit * nit * nit * nit * nit * nit * nit * nit * nit * nit * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * nit changes * nit changes * nit changes * nit changes * set title on the basis of selected topic in topic screen.other nit changes * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/java/org/oppia/app/home/HomeActivity.kt # app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt # app/src/main/java/org/oppia/app/topic/TopicActivity.kt # app/src/main/res/layout/home_fragment.xml * nit * nit * nit * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml * nit in TopicFragmentPresenter changed var to val in line number 69 * shorten stackoverflow link,testcase method name change * nit changes suggested by Rajat * nit * changes suggested by ben #230 (review) * nit * nit * nit
nikitamarysolomanpvt
added a commit
that referenced
this issue
Nov 8, 2019
* nit * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * Removed Topic and Exploration Button from HomeFragment, Removed topicButtonClick Implementation * nit * nit * test cases fix due to change in data. * nit * nit * nit
nikitamarysolomanpvt
added a commit
that referenced
this issue
Nov 8, 2019
nikitamarysolomanpvt
added a commit
that referenced
this issue
Nov 8, 2019
* multiple tabs * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * cust_args * test cases,multiple tabs will getting topic id from home Merge branch 'develop' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt # domain/src/main/java/org/oppia/domain/exploration/ExplorationRetriever.kt * nit * nit * nit * nit * nit * separate test cases for all four tabs * nit * nit * nit * nit * nit * nit * nit * nit * Topic Overview see more click and tab switch * Topic Overview see more click and tab switch * Topic Overview see more click and tab switch * topic id todo's are implemented, test cases updated as per new data through topic id * Topic Overview see more click and tab switch * nit * nit * merged with base branch * nit * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * set title on the basis of selected topic in topic screen.other nit changes * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/java/org/oppia/app/home/HomeActivity.kt # app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt # app/src/main/java/org/oppia/app/topic/TopicActivity.kt # app/src/main/res/layout/home_fragment.xml * nit * nit * nit * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml * nit in TopicFragmentPresenter changed var to val in line number 69 * nit * shorten stackoverflow link,testcase method name change * nit changes suggested by Rajat * nit * nit * used enum to set current tab in TopicFragmentPresenter. other nit changes. * nit * nit * nit * nit * nit * nit * nit * nit * Fix #135:Topic issues fixes part 2 (#318) * nit * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * Removed Topic and Exploration Button from HomeFragment, Removed topicButtonClick Implementation * nit * nit * test cases fix due to change in data. * nit * nit * nit * Revert "Fix #135:Topic issues fixes part 2 (#318)" This reverts commit cdd5c4d.
nikitamarysolomanpvt
added a commit
that referenced
this issue
Nov 11, 2019
* multiple tabs * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * cust_args * test cases,multiple tabs will getting topic id from home Merge branch 'develop' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt # domain/src/main/java/org/oppia/domain/exploration/ExplorationRetriever.kt * nit * nit * nit * nit * nit * separate test cases for all four tabs * nit * nit * nit * nit * nit * nit * nit * nit * Topic Overview see more click and tab switch * Topic Overview see more click and tab switch * Topic Overview see more click and tab switch * topic id todo's are implemented, test cases updated as per new data through topic id * Topic Overview see more click and tab switch * nit * nit * merged with base branch * nit * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * revert back to develop * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * set title on the basis of selected topic in topic screen.other nit changes * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/java/org/oppia/app/home/HomeActivity.kt # app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt # app/src/main/java/org/oppia/app/topic/TopicActivity.kt # app/src/main/res/layout/home_fragment.xml * nit * nit * nit * nit * Merge branches 'develop' and 'topic-player-multiple-tabs' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/src/main/AndroidManifest.xml * nit in TopicFragmentPresenter changed var to val in line number 69 * nit * shorten stackoverflow link,testcase method name change * nit changes suggested by Rajat * nit * nit * used enum to set current tab in TopicFragmentPresenter. other nit changes. * nit * nit * nit * nit * nit * nit * nit * nit * Fix #135:Topic issues fixes part 2 (#318) * nit * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * TopicTestActivityTest,TopicTestActivityForStory and TopicTestActivityForStoryTest introdused for testing topic multiple tabs * Removed Topic and Exploration Button from HomeFragment, Removed topicButtonClick Implementation * nit * nit * test cases fix due to change in data. * nit * nit * nit * nit
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is tracking introducing the UI structure for the topic page, including constituent tabs: train, play, overview, and review. This does not track introducing the UIs for each tab. See later in this issue for issues blocking this (4 of them should be the corresponding structure issues for each tab).
See #23 for the issue corresponding to the high-fidelity topic page work.
PromotedStoryinHomeshould openTopicPlayFragmentand scroll to a specific story item.The text was updated successfully, but these errors were encountered: