Resolve openstack-exporter#135 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikhail Sharkov <[email protected]>
shotgun-20
force-pushed
the
feature/resource_class
branch
2 times, most recently
from
ea6ad8d
to
9bcb35a
Compare
niedbalski
reviewed
Nov 6, 2020
VERSION
Outdated
| @@ -1 +1 @@ | |||
| 1.2.0 | |||
| 1.2.1 | |||
There was a problem hiding this comment.
There is no need to increase the version number, please revert this change.
There was a problem hiding this comment.
Done, reverted it.
|
@shotgun-20 hello, I am awaiting the tests to come back and please check the comment made on the VERSION file. |
shotgun-20
force-pushed
the
feature/resource_class
branch
from
1914b1a
to
dcc9434
Compare
|
Done, no version change here anymore. |
|
LGTM @shotgun-20 ,i'll wait for tests and merge. Once again thank you for your contributions! |
mzijdemans
pushed a commit
to mzijdemans/openstack-exporter
that referenced
this pull request
Dec 27, 2022
* ironic microversion workaround (openstack-exporter#135) Co-authored-by: Mikhail Sharkov <[email protected]> * add baremetal resource_class metric Co-authored-by: Mikhail Sharkov <[email protected]> Co-authored-by: Jorge Niedbalski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ironic exporter now checks for API microversion. Also, baremetal resource_class metric is added. Release tarballs added to gitignore.