Baremetal exporter misses some states and node names

[ftarasenko]

Hi,

I have problem getting node names and some states from baremetal exporter. In example below we can see that nodes miss names and provision_state.

# TYPE openstack_ironic_node gauge
openstack_ironic_node{console_enabled="false",id="2ab373f4-db7c-4348-87ec-bd6eda8f0aef",maintenance="false",name="",power_state="power on",provision_state="inspect failed"} 1
openstack_ironic_node{console_enabled="false",id="9ae2c5a4-22c9-48e2-a255-42a89dc8c567",maintenance="false",name="",power_state="power off",provision_state=""} 1
openstack_ironic_node{console_enabled="false",id="bffe7168-99ee-483a-b149-2c9f53501f70",maintenance="false",name="",power_state="power off",provision_state="manageable"} 1
openstack_ironic_node{console_enabled="false",id="fe110a59-0f85-4f1b-8823-bbd634abfae4",maintenance="false",name="",power_state="power on",provision_state="active"} 1

As a quick fix, I can set Microversion of Ironic Client to 1.58 and get node's names and correct states.

 // ListNodes : list nodes
 func ListNodes(exporter *BaseOpenStackExporter, ch chan<- prometheus.Metric) error {
+       exporter.Client.Microversion = "1.58"
        allPagesNodes, err := nodes.List(exporter.Client, nodes.ListOpts{}).AllPages()
        if err != nil {
                return err

And result is

openstack_ironic_node{console_enabled="false",id="2ab373f4-db7c-4348-87ec-bd6eda8f0aef",maintenance="false",name="node-sl-pca22",power_state="power on",provision_state="inspect failed"} 1
openstack_ironic_node{console_enabled="false",id="9ae2c5a4-22c9-48e2-a255-42a89dc8c567",maintenance="false",name="node-sl-pca23",power_state="power off",provision_state="available"} 1
openstack_ironic_node{console_enabled="false",id="bffe7168-99ee-483a-b149-2c9f53501f70",maintenance="false",name="node-sl-pca334",power_state="power off",provision_state="manageable"} 1
openstack_ironic_node{console_enabled="false",id="fe110a59-0f85-4f1b-8823-bbd634abfae4",maintenance="false",name="node-sl-pca325",power_state="power on",provision_state="active"} 1

I beleive that microversion check should be added to Ironic client (maybe others?)

Current behaviour of console client is to ask for maximum version, get supported version list if maximum is not supported and use best version available.

Tnx!