Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Update transifex config #1598

Merged
merged 1 commit into from
Jan 18, 2024
Merged

(chore) Update transifex config #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion .tx/config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
[main]
host = https://www.transifex.com

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-form-engine-app]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher, is this o: prefix necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's Transifex's syntax. (o: for org, p: for project, r: for resource)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking the results and command instructions, it seems that the new version of Transifex requires an additional parameter to be configured: "resource_name". Otherwise, the new added resource name displayed on Transifex will default to "en.json".

I will submit another PR soon.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably because en.json is treated as the "master list" of strings to be translated.

Copy link
Contributor Author

@befantasy befantasy Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. How should we go about solving this issue?
After the PR was merged, I still see that this issue has not been resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@befantasy Yeah, I don't think it's determined by the configuration file or it may be that the resources need to be manually renamed after they were created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher Oh, I see. Thank you for your patient explanation. So do you know how and by whom should the manual renaming be conducted? I'm stuck with this issue.

file_filter = packages/esm-form-engine-app/translations/<lang>.json
source_file = packages/esm-form-engine-app/translations/en.json
source_lang = en
type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-form-entry-app]
file_filter = packages/esm-form-entry-app/translations/<lang>.json
source_file = packages/esm-form-entry-app/translations/en.json
Expand Down Expand Up @@ -65,6 +73,14 @@ type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-flags-app]
file_filter = packages/esm-patient-flags-app/translations/<lang>.json
source_file = packages/esm-patient-flags-app/translations/en.json
source_lang = en
type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-forms-app]
file_filter = packages/esm-patient-forms-app/translations/<lang>.json
source_file = packages/esm-patient-forms-app/translations/en.json
Expand All @@ -89,6 +105,14 @@ type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-lists-app]
file_filter = packages/esm-patient-lists-app/translations/<lang>.json
source_file = packages/esm-patient-lists-app/translations/en.json
source_lang = en
type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-medications-app]
file_filter = packages/esm-patient-medications-app/translations/<lang>.json
source_file = packages/esm-patient-medications-app/translations/en.json
Expand All @@ -105,6 +129,14 @@ type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-orders-app]
file_filter = packages/esm-patient-orders-app/translations/<lang>.json
source_file = packages/esm-patient-orders-app/translations/en.json
source_lang = en
type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-patient-programs-app]
file_filter = packages/esm-patient-programs-app/translations/<lang>.json
source_file = packages/esm-patient-programs-app/translations/en.json
Expand All @@ -120,4 +152,3 @@ source_lang = en
type = KEYVALUEJSON
replace_edited_strings = false
keep_translations = false

Loading