Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update transifex config #1598

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

befantasy
Copy link
Contributor

@befantasy befantasy commented Jan 18, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR updates the config to sync with the transifex project

Screenshots

Related Issue

Other

update the config to sync with the transifex project
@befantasy befantasy changed the title Update config Update transifex config Jan 18, 2024
@denniskigen denniskigen changed the title Update transifex config (chore) Update transifex config Jan 18, 2024
@@ -1,6 +1,14 @@
[main]
host = https://www.transifex.com

[o:openmrs:p:openmrs-esm-patient-chart:r:esm-form-engine-app]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher, is this o: prefix necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's Transifex's syntax. (o: for org, p: for project, r: for resource)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking the results and command instructions, it seems that the new version of Transifex requires an additional parameter to be configured: "resource_name". Otherwise, the new added resource name displayed on Transifex will default to "en.json".

I will submit another PR soon.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably because en.json is treated as the "master list" of strings to be translated.

Copy link
Contributor Author

@befantasy befantasy Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. How should we go about solving this issue?
After the PR was merged, I still see that this issue has not been resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@befantasy Yeah, I don't think it's determined by the configuration file or it may be that the resources need to be manually renamed after they were created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher Oh, I see. Thank you for your patient explanation. So do you know how and by whom should the manual renaming be conducted? I'm stuck with this issue.

@denniskigen
Copy link
Member

Thanks, @befantasy!

@denniskigen denniskigen merged commit bd62b36 into openmrs:main Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants