Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUNK-6196: Email sending fails due to errors with velocity log conf… #4399

Merged
merged 2 commits into from
Oct 6, 2023
Merged

TRUNK-6196: Email sending fails due to errors with velocity log conf… #4399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b47825
TRUNK-6196 - Email sending fails due to errors with velocity log conf…
mseaton Oct 6, 2023
6aab879
Change from SimpleLog4JLogSystem to Log4JLogChute
mseaton Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/src/main/java/org/openmrs/notification/mail/velocity/VelocityMessagePreparator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
package org.openmrs.notification.mail.velocity;

import java.io.StringWriter;
import java.util.Properties;

import org.apache.velocity.VelocityContext;
import org.apache.velocity.app.VelocityEngine;
Expand Down Expand Up @@ -40,7 +41,11 @@ public class VelocityMessagePreparator implements MessagePreparator {
public VelocityMessagePreparator() throws MessageException {
try {
engine = new VelocityEngine();
engine.init();
Properties props = new Properties();
props.put("runtime.log.logsystem.class", "org.apache.velocity.runtime.log.SimpleLog4JLogSystem");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like Velocity recommends the Log4JLogChuteclass over this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Want to have a look?

props.put("runtime.log.logsystem.log4j.category", "velocity");
props.put("runtime.log.logsystem.log4j.logger", "velocity");
engine.init(props);
}
catch (Exception e) {
log.error("Failed to create velocity engine " + e.getMessage(), e);
Expand Down