TRUNK-6196: Email sending fails due to errors with velocity log conf… #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
changed the title
ibacher
reviewed
Oct 6, 2023
| @@ -40,7 +41,11 @@ public class VelocityMessagePreparator implements MessagePreparator { | |||
| public VelocityMessagePreparator() throws MessageException { | |||
| try { | |||
| engine = new VelocityEngine(); | |||
| engine.init(); | |||
| Properties props = new Properties(); | |||
| props.put("runtime.log.logsystem.class", "org.apache.velocity.runtime.log.SimpleLog4JLogSystem"); | |||
There was a problem hiding this comment.
It does look like Velocity recommends the Log4JLogChuteclass over this one.
There was a problem hiding this comment.
Changed. Want to have a look?
mogoodrich
approved these changes
Oct 6, 2023
mseaton
added a commit
that referenced
this pull request
Oct 6, 2023
mseaton
added a commit
that referenced
this pull request
Oct 6, 2023
Wandji69
pushed a commit
to Wandji69/openmrs-core
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iguration
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6196