TRUNK-5065: Add tests to AdministrationServiceImpl

[PKatGITHUB]

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5065

Checklist: I completed these to help reviewers :)

• My pull request only contains ONE single commit
  (the number above, next to the 'Commits' tab is 1).

  No? -> read here on how to squash multiple commits into one

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[coveralls]

Coverage increased (+0.03%) to 58.946% when pulling e8b441d on PKatGITHUB:TRUNK-5065 into 1475c8a on openmrs:master.

[teleivo]

replace test with provided one

[teleivo]

almost, you did need to change variable names and the assert (although I think we can even remove it)

	@Test
	public void saveGlobalProperty_shouldFailIfGivenDefaultLocaleIsNotInAllowedLocales() {

		Locale defaultLocale = new Locale("fr");

		expectedException.expect(APIException.class);
		expectedException.expectMessage("is not in allowed locales list");

		adminService.saveGlobalProperty(
			new GlobalProperty(OpenmrsConstants.GLOBAL_PROPERTY_DEFAULT_LOCALE, defaultLocale.toString()));
	}

[PKatGITHUB]

Done :)

Thank you @teleivo :)

What Next?

[teleivo]

@PKatGITHUB pick on test that is currently ignored, try to find the one that seems simplest to you, and have a look if the test is still needed

• is the case it says its testing covered by another test, than delete the test
• if not than try to fix it so we can remove the @Ignore