Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5065: Add tests to AdministrationServiceImpl #2648

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

PKatGITHUB
Copy link
Contributor

@PKatGITHUB PKatGITHUB commented Apr 6, 2018

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5065

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 58.733% when pulling 31e64b3 on PKatGITHUB:TRUNK-5065 into bbca156 on openmrs:master.

@teleivo teleivo merged commit 61589a8 into openmrs:master Apr 7, 2018
@teleivo
Copy link
Member

teleivo commented Apr 7, 2018

@PKatGITHUB awesome!!!

@PKatGITHUB
Copy link
Contributor Author

Thank you @teleivo !!!

@PKatGITHUB
Copy link
Contributor Author

@teleivo what next :) ?

@teleivo
Copy link
Member

teleivo commented Apr 9, 2018

@PKatGITHUB I cleaned AdministrationServiceTest up a bit so tests should be bit easier to read now.
I added one test case for saveGlobalProperty when saving the global property for
GLOBAL_PROPERTY_LOCALE_ALLOWED_LIST

see
dc33df6

you could now add the case for

the method saveGlobalProperty when saving the global property for GLOBAL_PROPERTY_DEFAULT_LOCALE fails using this style/template :)

@PKatGITHUB
Copy link
Contributor Author

Hey @teleivo thanks for all your support :)
I have created one more PR. Have a look at #2650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants