Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Insurance Company Service allow setting id and make phone settings optional #7217

Closed
adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7218
Closed

feat: Insurance Company Service allow setting id and make phone settings optional #7217

adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7218
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

When importing / transferring data into OpenEMR it is helpful to be able to set the specific id of the insurance company in the service class. Also, if there are no phone settings in the data we should skip creating phone information as part of the service.

Lastly, if the service fails to update / insert we should have it throw an exception instead of silently fail.
@adunsulag adunsulag self-assigned this Feb 11, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Feb 11, 2024
@adunsulag
Fixes openemr#7216,openemr#7217 insurance company saves
4526727 
We fix openemr#7216 where we populate the plus_four property in the address
service.

Fixes openemr#7217 where we allow the record id to be set / saved on insert.
We also throw exceptions if the sql command fails.
Lastly we skip saving the phone number if there is nothing in the data.
@adunsulag adunsulag mentioned this issue Feb 11, 2024
Merged
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Feb 13, 2024
@adunsulag
Fixes openemr#7224, openemr#7217 insurance company changes
8be13d7 
Fixed the list loading taking forever on the insurance company list.
This fixes openemr#7224.

Had a bug in the fix for openemr#7217 so this fixes that as well. Wasn't
actually replacing the insurance id.
@adunsulag adunsulag mentioned this issue Feb 13, 2024
Merged
adunsulag added a commit that referenced this issue Feb 14, 2024
@adunsulag
Fixes #7224, #7217 insurance company changes (#7225)
b4fdaef 
* Fixes #7224, #7217 insurance company changes

Fixed the list loading taking forever on the insurance company list.
This fixes #7224.

Had a bug in the fix for #7217 so this fixes that as well. Wasn't
actually replacing the insurance id.

* Remove about title tag

* Change escaping function on webroot
sjpadgett added a commit to sjpadgett/openemr that referenced this issue Feb 15, 2024
@sjpadgett
Merge branch 'master' of https://github.com/openemr/openemr into weno…
06a2fd8 
…_daily

* 'master' of https://github.com/openemr/openemr:
  Fixes openemr#7224, openemr#7217 insurance company changes (openemr#7225)
  fix: bug fix (openemr#7230)
  bug: fix bug (openemr#7229)
  Fixes openemr#7226 Insurance company address query (openemr#7227)
  fix: possible fix of logic in jquery-datetimepicker-2-5-4-translated.js (openemr#7223)
stephenwaite pushed a commit to stephenwaite/openemr that referenced this issue Mar 11, 2024
@adunsulag @stephenwaite
Fixes openemr#7216,openemr#7217 insurance company saves (openemr#7218)
cd520ba 
We fix openemr#7216 where we populate the plus_four property in the address
service.

Fixes openemr#7217 where we allow the record id to be set / saved on insert.
We also throw exceptions if the sql command fails.
Lastly we skip saving the phone number if there is nothing in the data.
stephenwaite pushed a commit to stephenwaite/openemr that referenced this issue Mar 11, 2024
@adunsulag @stephenwaite
Fixes openemr#7224, openemr#7217 insurance company changes (openemr#7225
34be6f2 
)

* Fixes openemr#7224, openemr#7217 insurance company changes

Fixed the list loading taking forever on the insurance company list.
This fixes openemr#7224.

Had a bug in the fix for openemr#7217 so this fixes that as well. Wasn't
actually replacing the insurance id.

* Remove about title tag

* Change escaping function on webroot
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 2, 2024
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7216,#7217 insurance company saves DiscoverAndChange/openemr
1 participant
@adunsulag