Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add zipcode plus_four to address service / apis #7216

Closed
adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7218
Closed

feat: Add zipcode plus_four to address service / apis #7216

adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7218
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

In the address service class / apis the plus_four property is not included. We should expose this in the services / standard rest api.
@adunsulag adunsulag self-assigned this Feb 11, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Feb 11, 2024
@adunsulag
Fixes openemr#7216,openemr#7217 insurance company saves
4526727 
We fix openemr#7216 where we populate the plus_four property in the address
service.

Fixes openemr#7217 where we allow the record id to be set / saved on insert.
We also throw exceptions if the sql command fails.
Lastly we skip saving the phone number if there is nothing in the data.
@adunsulag adunsulag mentioned this issue Feb 11, 2024
Merged
adunsulag added a commit that referenced this issue Feb 12, 2024
@adunsulag
Fixes #7216,#7217 insurance company saves (#7218)
374095a 
We fix #7216 where we populate the plus_four property in the address
service.

Fixes #7217 where we allow the record id to be set / saved on insert.
We also throw exceptions if the sql command fails.
Lastly we skip saving the phone number if there is nothing in the data.
stephenwaite pushed a commit to stephenwaite/openemr that referenced this issue Mar 11, 2024
@adunsulag @stephenwaite
Fixes openemr#7216,openemr#7217 insurance company saves (openemr#7218)
cd520ba 
We fix openemr#7216 where we populate the plus_four property in the address
service.

Fixes openemr#7217 where we allow the record id to be set / saved on insert.
We also throw exceptions if the sql command fails.
Lastly we skip saving the phone number if there is nothing in the data.
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 2, 2024
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7216,#7217 insurance company saves DiscoverAndChange/openemr
1 participant
@adunsulag