Remove unified CRLs, cross-cluster revocations #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
remove-unified-crl
branch
2 times, most recently
from
3efc5fb
to
3de9993
Compare
DanGhita
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Well, it seems OK for me.
However, while I understand the rational behind this, the changes (cleaning) are important.
So I could not guarantee there is no regression for nominal CRL (without cross or unified validation).
I hope the tests are complete enough to catch any side effects.
|
Thanks @DanGhita -- there are extensive tests still left testing CRLs in |
In Vault Enterprise's split-storage clustering (Performance Secondary), the PKI engine needed a way of maintaining a single, unified CRL across all Perf Secondary clusters and accepting revocations given to any cluster for certs stored on any other cluster. The combination of Unified CRLs and Revocation Queues solved this problem for Vault Enterprise, but the code largely lived in Vault Community. Since OpenBao lacks these clustering semantics and is unlikely to add them, remove this code. Resolves: openbao#272 Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
remove-unified-crl
branch
from
3de9993
to
d76a440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vault Enterprise's split-storage clustering (Performance Secondary), the PKI engine needed a way of maintaining a single, unified CRL across all Perf Secondary clusters and accepting revocations given to any cluster for certs stored on any other cluster. The combination of Unified CRLs and Revocation Queues solved this problem for Vault Enterprise, but the code largely lived in Vault Community.
Since OpenBao lacks these clustering semantics and is unlikely to add them, remove this code.
Resolves: #272
Based on #362; will be rebased once that merges.