Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last vestiges of Unified CRL #272

Closed
cipherboy opened this issue Apr 6, 2024 · 0 comments · Fixed by #365
Closed

Remove last vestiges of Unified CRL #272

cipherboy opened this issue Apr 6, 2024 · 0 comments · Fixed by #365
Labels
bug Something isn't working
Milestone

Comments

@cipherboy
Copy link
Member

See e.g., https://github.com/openbao/openbao/blob/main/builtin/logical/pki/path_fetch_issuers.go#L1214-L1223 -- and similar locations.

There's many places where cross-cluster Unified CRLs still exist in the code base, despite being a Vault Enterprise (and in particular, Performance Secondary) scenario. We should remove these, prior to GA.

@cipherboy cipherboy added the bug Something isn't working label Apr 6, 2024
cipherboy added a commit to cipherboy/openbao that referenced this issue Jun 15, 2024
In Vault Enterprise's split-storage clustering (Performance Secondary),
the PKI engine needed a way of maintaining a single, unified CRL across
all Perf Secondary clusters and accepting revocations given to any
cluster for certs stored on any other cluster. The combination of
Unified CRLs and Revocation Queues solved this problem for Vault
Enterprise, but the code largely lived in Vault Community.

Since OpenBao lacks these clustering semantics and is unlikely to add
them, remove this code.

Resolves: openbao#272

Signed-off-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy added this to the 2.0.0 - GA milestone Jun 15, 2024
cipherboy added a commit to cipherboy/openbao that referenced this issue Jun 20, 2024
In Vault Enterprise's split-storage clustering (Performance Secondary),
the PKI engine needed a way of maintaining a single, unified CRL across
all Perf Secondary clusters and accepting revocations given to any
cluster for certs stored on any other cluster. The combination of
Unified CRLs and Revocation Queues solved this problem for Vault
Enterprise, but the code largely lived in Vault Community.

Since OpenBao lacks these clustering semantics and is unlikely to add
them, remove this code.

Resolves: openbao#272

Signed-off-by: Alexander Scheel <[email protected]>
cipherboy added a commit to cipherboy/openbao that referenced this issue Jun 20, 2024
In Vault Enterprise's split-storage clustering (Performance Secondary),
the PKI engine needed a way of maintaining a single, unified CRL across
all Perf Secondary clusters and accepting revocations given to any
cluster for certs stored on any other cluster. The combination of
Unified CRLs and Revocation Queues solved this problem for Vault
Enterprise, but the code largely lived in Vault Community.

Since OpenBao lacks these clustering semantics and is unlikely to add
them, remove this code.

Resolves: openbao#272

Signed-off-by: Alexander Scheel <[email protected]>
cipherboy added a commit to cipherboy/openbao that referenced this issue Jul 10, 2024
In Vault Enterprise's split-storage clustering (Performance Secondary),
the PKI engine needed a way of maintaining a single, unified CRL across
all Perf Secondary clusters and accepting revocations given to any
cluster for certs stored on any other cluster. The combination of
Unified CRLs and Revocation Queues solved this problem for Vault
Enterprise, but the code largely lived in Vault Community.

Since OpenBao lacks these clustering semantics and is unlikely to add
them, remove this code.

Resolves: openbao#272

Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant