Fix go tests #362
Merged
Fix go tests #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2024
DanGhita
approved these changes
Jun 17, 2024
Signed-off-by: Alexander Scheel <[email protected]>
This removes unnecessary pipeline executions as we've replaced the upstream release tooling with goreleaser. Signed-off-by: Alexander Scheel <[email protected]>
When reverting SSCTs in 15c4855, this did not correctly handle making the config DisableSSCTs value a pointer, resulting in a failure when running with external (Docker) binaries and potentially full (non-dev-mode) server instances. Signed-off-by: Alexander Scheel <[email protected]>
When using `caddy start` with RunCmdWithOutput(...), the container runner prematurely terminates the backgrounded Caddy server when the latter function call returns. This prevents the subsequent curl from working as the server has already been shut down. Switch to running the interactive variant (`caddy run`) in the background explicitly via RunCmdInBackground(...). Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Go tests may not log after the end of the test as this will panic the logger. Signed-off-by: Alexander Scheel <[email protected]>
|
Thanks all! I've signed the commits, going to go ahead and merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Go tests broken by #321 that were not caught prior to merging (plugin compatibility, external binary testing panic caused by reverting SSCT removal, an issue with the Caddy EAB test, and a stray log statement post-test that Go now panics on).
Also removes the obsolete upstream build process and fixes the missing UI page to mention OpenBao.