Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the code platform-agnostic would lead to more contributions #209

Closed
jonathanagustin opened this issue Mar 16, 2023 · 7 comments
Closed

Comments

@jonathanagustin
Copy link
Contributor

jonathanagustin commented Mar 16, 2023

I observed that the example Jupyter notebooks contain OS-specific code. For example, in evals/examples/lafand-mt.ipynb, there is an assumption of a Unix filesystem:

events = f"/tmp/evallogs/{log_name}"

Here, it seems better to use Python's tempfile module to handle temporary files and directories across different platforms.

In evals/examples/mmlu.ipynb, there are these commands:

!curl -O https://people.eecs.berkeley.edu/~hendrycks/data.tar
!tar -xf data.tar

Here, it seems better to use a Python library like urllib to download datasets because it is built into the language and is usable across different operating systems.

Multi-platform support would lead to more contributions. Instead of using Unix-specific methods to handle the filesystem, Python libraries can be used instead. Using a Python library would generally handle most of the OS-specific issues.

I do not have any specific problems, but I recognize that others may not have access to different operating systems. Perhaps they may not be technically proficient enough to use WSL or Docker.

@jonathanagustin jonathanagustin changed the title Better support for Windows Better support for Windows would lead to more contributions Mar 16, 2023
@mstooks
Copy link

mstooks commented Mar 16, 2023

+1

@Tshering-Penjor
Copy link

I think it supports all OS and more importantly all versions of windows.

@SinanAkkoyun
Copy link
Contributor

Just install WSL if you're on windows, it should work flawlessly

@Toby-Mascot
Copy link

Installing WSL should do the trick

@jonathanagustin
Copy link
Contributor Author

@Toby-Mascot @SinanAkkoyun

I understand that WSL is a solution. My concern is that WSL may be difficult to install for some. I also recognize that Unix-based OS is also difficult for some to learn as well. The aim is to make it more platform agnostic: Using Python libraries will achieve this aim and facilitate more contributions.

@jonathanagustin jonathanagustin changed the title Better support for Windows would lead to more contributions Making the code platform-agnostic would lead to more contributions Mar 16, 2023
@Toby-Mascot
Copy link

Toby-Mascot commented Mar 16, 2023 via email

@logankilpatrick
Copy link
Contributor

Most of the dev team at OpenAI uses MacOS, but you are welcome to open a PR to add windows related info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants