-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows path and unicode decoding #379
Comments
This is partly related to. |
I'm trying to make a PR for this. The PR will address the separator issue by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I am trying to contribute and get access to GPT-4 by creating my own evals but I thought that I need to be able to run evals before starting. So, I was trying to figure out how to run an eval following one of your examples, "lafand-mt.ipynb", when I found out two problems that resulted in errors for me.
langs = input_path.split('/')[-1]
would find the '-' in the path "...\lafand-mt" and thus bring three elements inlangs.split('-')
. For instance, [ "...\data\lafand", "mt\en", "amh"]. This breaks the following line as the output has three elements and is not in the expected formatinput_lang, output_lang = langs.split('-')
. I was able to bodge it by changing '/' to '\' but this should not be the community-standard solution. Furthermore, I would not want Windows users who do not know about this to get lost while following your example.UnicodeDecodeError
. I do not know if this happens to other users but I suggest that you add to the main branchencoding='utf-8'
as another parameter for.open()
in line 6 as it seems to get rid of the error.Keep up the good work!
The text was updated successfully, but these errors were encountered: