Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename core classes #251

Merged
merged 31 commits into from
May 8, 2024
Merged

rename core classes #251

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4a884c0
rename core classes
andrewparmet Apr 22, 2024
a930887
fix
andrewparmet Apr 22, 2024
edc6e56
any fixes
andrewparmet Apr 22, 2024
40fbef4
more fixes
andrewparmet Apr 22, 2024
254e4f1
more
andrewparmet Apr 22, 2024
f53b184
partial api dump
andrewparmet Apr 22, 2024
2e42129
more
andrewparmet Apr 22, 2024
bf95c14
fixes
andrewparmet Apr 22, 2024
8b1f5a1
more changes
andrewparmet Apr 22, 2024
9642f4c
more fixes
andrewparmet Apr 22, 2024
38ddbdf
bump gradle
andrewparmet Apr 22, 2024
6ac3078
fix
andrewparmet Apr 22, 2024
861be1a
more renaming
andrewparmet May 8, 2024
e3302a9
more adjustments
andrewparmet May 8, 2024
d62d2ca
more changes
andrewparmet May 8, 2024
4a7e632
more linting
andrewparmet May 8, 2024
551a2d0
fixes
andrewparmet May 8, 2024
8d09354
remove redundant suppression
andrewparmet May 8, 2024
0fc6649
more adjustments
andrewparmet May 8, 2024
94d3930
compilation
andrewparmet May 8, 2024
355e306
pick a name that cannot conflict with protobuf field; calculate lazily
andrewparmet May 8, 2024
b76fc3f
-_-
andrewparmet May 8, 2024
600459c
empty
andrewparmet May 8, 2024
7e45b70
try another name
andrewparmet May 8, 2024
81799b9
Revert "try another name"
andrewparmet May 8, 2024
2110aa3
try installing firefox
andrewparmet May 8, 2024
7a51bdb
foo
andrewparmet May 8, 2024
a3b1009
try accessing path
andrewparmet May 8, 2024
cd92064
another try
andrewparmet May 8, 2024
32ce532
ah, it was overridden
andrewparmet May 8, 2024
a135690
put back override in yml
andrewparmet May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
put back override in yml
  • Loading branch information
@andrewparmet
andrewparmet committed May 8, 2024
commit a135690a91d9844942186ff955493e3c1f9e9842
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- uses: browser-actions/setup-firefox@v1
id: firefox-install
- name: Build and test
# env:
# FIREFOX_BIN: ${{steps.firefox-install.outputs.firefox-path}}
env:
FIREFOX_BIN: ${{steps.firefox-install.outputs.firefox-path}}
run: ./gradlew "-Dkotlin-integration.version=${{ matrix.kotlin }}" clean build --stacktrace --no-daemon
working-directory: gradle-plugin-integration-test