Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename core classes #251

Merged
merged 31 commits into from
May 8, 2024
Merged

Conversation

andrewparmet
Copy link
Collaborator

@andrewparmet andrewparmet commented Apr 22, 2024

  • Get rid of kt prefixes
  • messageSize is a function so it can't conflict with a field message_size
  • We had three "serializer" names: KtDeserializer, KtMessageDeserializer, and KtMessageSerializer. The second and third are mostly internal. I renamed them Writer and Encoder to try to highlight that, but I don't love that name. I just can't think of better. Open to suggestions. Other options are Writer and Reader; pb-and-k uses Marshaller and Unmarshaller; Javaland's equivalents are the coded streams. used Reader and Writer

@andrewparmet andrewparmet marked this pull request as ready for review April 22, 2024 13:42
@file:JvmName("AnyUtil")
@file:JvmName("Anies")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewparmet andrewparmet merged commit 4b5dce1 into open-toast:main May 8, 2024
13 checks passed
@andrewparmet andrewparmet deleted the rename-core-classes branch May 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants