BREAKING rename net.app.protocol.(name|version) to net.protocol.(name|version) and replace http.flavor with net.protocol.(name|version)
#3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.app.transport.(name|version) to net.transport.(name|version) and replaces http.flavor with net.transport.(name|version)net.app.transport.(name|version) to net.transport.(name|version) and replace http.flavor with net.transport.(name|version)
78d9bcb
to
bbd13ac
Compare
trask
commented
Mar 2, 2023
lmolkova
reviewed
Mar 2, 2023
Co-authored-by: Liudmila Molkova <[email protected]>
trask
commented
Mar 2, 2023
net.app.transport.(name|version) to net.transport.(name|version) and replace http.flavor with net.transport.(name|version)net.app.protocol.(name|version) to net.protocol.(name|version) and replace http.flavor with net.protocol.(name|version)
lmolkova
approved these changes
Mar 2, 2023
jsuereth
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
LGTM - as I think it's ok to default protocol to the application-layer and then provide other protocol attributes for non-standard layer protocols, but was curious if the intent here is just to use protocol.name as the "outermost"/"highest" protocol used in the trace?
mateuszrzeszutek
approved these changes
Mar 6, 2023
pyohannes
approved these changes
Mar 7, 2023
jack-berg
approved these changes
Mar 8, 2023
mateuszrzeszutek
pushed a commit
to open-telemetry/opentelemetry-java-instrumentation
that referenced
this pull request
Mar 9, 2023
reyang
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3215 -- renaming
net.app.protocol.(name|version)tonet.protocol.(name|version)Fixes #2626 -- replacing
http.flavorwithnet.protocol.(name|version)Changes
Renames
net.app.protocol.(name|version)tonet.protocol.(name|version)and replaceshttp.flavorwithnet.protocol.(name|version).Note: there's no schema transformation available today for splitting
http.flavorintonet.protocol.(name|version)(#3162)