Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from http.flavor to net.protocol.* in HTTP server instrumentat… #8244

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

mateuszrzeszutek
Copy link
Member

…ions

Continuation of #8131
Implements the other half of the open-telemetry/opentelemetry-specification#3272 spec PR
Resolves #4519

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner April 7, 2023 11:48
@mateuszrzeszutek mateuszrzeszutek added this to the v1.25.0 milestone Apr 7, 2023
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@trask trask merged commit 5b271c4 into open-telemetry:main Apr 9, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the net.protocol-server branch April 11, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't extract http.flavor if the instrumented library does not provide a way to retrieve it
2 participants