Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange the file structure of RocketMQ instrumentation #6762

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Rearrange the file structure of RocketMQ instrumentation #6762

merged 2 commits into from
Sep 28, 2022

Conversation

aaron-ai
Copy link
Member

Fixes #6761

@aaron-ai aaron-ai requested a review from a team September 27, 2022 09:11
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_directory branch 2 times, most recently from 1fb6c26 to 5ec7d42 Compare September 27, 2022 09:43
trask
trask reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, though we don't generally create the additional module hierarchy proactively

...main/java/io/opentelemetry/javaagent/instrumentation/rocketmqclient/RocketMqClientHooks.java Outdated Show resolved Hide resolved
@aaron-ai aaron-ai force-pushed the feature/add_rocketmq_directory branch from 5ec7d42 to 48ed7cf Compare September 28, 2022 05:25
@aaron-ai aaron-ai requested a review from trask September 28, 2022 05:51
laurit
laurit reviewed Sep 28, 2022
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
@trask trask merged commit 4e59f10 into open-telemetry:main Sep 28, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
604bc5e 
…try#6762)

Fixes open-telemetry#6761
@aaron-ai aaron-ai mentioned this pull request Oct 27, 2022
Closed
6 tasks
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
9acb735 
…try#6762)

Fixes open-telemetry#6761
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
b9ff541 
…try#6762)

Fixes open-telemetry#6761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rearrange the file structure of RocketMQ instrumentation
3 participants
@aaron-ai @trask @laurit