Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange the file structure of RocketMQ instrumentation #6761

Closed
aaron-ai opened this issue Sep 27, 2022 · 1 comment · Fixed by #6762
Closed

Rearrange the file structure of RocketMQ instrumentation #6761

aaron-ai opened this issue Sep 27, 2022 · 1 comment · Fixed by #6762
Labels
enhancement New feature or request

Comments

@aaron-ai
Copy link
Member

Since gRPC/Protobuf-based RocketMQ client is released, we may have multiple implementations of Apache RocketMQ client, and they have totally different maven coordinates and APIs. RocketMQ community intend to implement the OpenTelemetry instrumentation of new client recently.

What's more, the server-side instrumentation of Apache RocketMQ may be contributed in the future. Maybe it is time to rearrange the file structure of RocketMQ instrumentation.
@aaron-ai aaron-ai added the enhancement New feature or request label Sep 27, 2022
@aaron-ai aaron-ai changed the title Move rocketmq-client-4.8 to rocketmq/rocketmq-clients Rearrange the file structure of RocketMQ instrumentation Sep 27, 2022
@aaron-ai aaron-ai mentioned this issue Sep 27, 2022
Merged
@aaron-ai
Copy link
Member Author

aaron-ai commented Sep 27, 2022 •
edited
Loading

releated issue: #6741 #6764

trask pushed a commit that referenced this issue Sep 28, 2022
@aaron-ai
Rearrange the file structure of RocketMQ instrumentation (#6762)
4e59f10 
Fixes #6761
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this issue Oct 23, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
604bc5e 
…try#6762)

Fixes open-telemetry#6761
@aaron-ai aaron-ai mentioned this issue Oct 27, 2022
Closed
6 tasks
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this issue Oct 31, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
9acb735 
…try#6762)

Fixes open-telemetry#6761
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this issue Dec 4, 2022
@aaron-ai @LironKS
Rearrange the file structure of RocketMQ instrumentation (open-teleme…
b9ff541 
…try#6762)

Fixes open-telemetry#6761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rearrange the file structure of RocketMQ instrumentation aaron-ai/opentelemetry-java-instrumentation
1 participant
@aaron-ai