Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run muzzle check against OpenTelemetry API instrumentation (bridge) #4797

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Run muzzle check against OpenTelemetry API instrumentation (bridge) #4797

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73bddb3
Run muzzle check against bridge
trask Dec 4, 2021
3327a7e
Merge remote-tracking branch 'upstream/main' into run-muzzle-check-ag…
trask Dec 5, 2021
0f65e09
Simplify
trask Dec 5, 2021
3015b63
Merge remote-tracking branch 'upstream/main' into run-muzzle-check-ag…
trask Dec 6, 2021
72d9aa2
Renames
trask Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify
  • Loading branch information
@trask
trask committed Dec 5, 2021
commit 0f65e09fb5e39f8a9b52a79f0a8d5ee839a3529c
2 changes: 1 addition & 1 deletion gradle-plugins/src/main/kotlin/io.opentelemetry.instrumentation.muzzle-check.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ val muzzleBootstrap: Configuration by configurations.creating {
}

val muzzleShadow by tasks.registering(ShadowJar::class) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this shadow jar is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shades the javaagent module classes themselves

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it to shadedModule then? Or something similar. We don't shade muzzle here, do we?

from(tasks.jar.get().archiveFile.get())
from(tasks.jar)

configurations = listOf(project.configurations.runtimeClasspath.get())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is default, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults are only applied to the default "shadowJar" task, see GradleUp/shadow#108 (comment)


Expand Down