Run muzzle check against OpenTelemetry API instrumentation (bridge) #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
run-muzzle-check-against-bridge
branch
4 times, most recently
from
35b53c5
to
22f130d
Compare
trask
changed the title
trask
force-pushed
the
run-muzzle-check-against-bridge
branch
from
22f130d
to
05a7827
Compare
trask
force-pushed
the
run-muzzle-check-against-bridge
branch
from
05a7827
to
73bddb3
Compare
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
iNikem
reviewed
Dec 5, 2021
gradle-plugins/src/main/kotlin/io.opentelemetry.instrumentation.muzzle-check.gradle.kts
Outdated
Show resolved
Hide resolved
| val muzzleShadow by tasks.registering(ShadowJar::class) { | ||
| from(tasks.jar.get().archiveFile.get()) | ||
|
|
||
| configurations = listOf(project.configurations.runtimeClasspath.get()) |
There was a problem hiding this comment.
defaults are only applied to the default "shadowJar" task, see johnrengelman/shadow#108 (comment)
| val muzzleBootstrap: Configuration by configurations.creating { | ||
| isCanBeConsumed = false | ||
| isCanBeResolved = true | ||
| } | ||
|
|
||
| val muzzleShadow by tasks.registering(ShadowJar::class) { |
There was a problem hiding this comment.
I don't understand why this shadow jar is needed?
There was a problem hiding this comment.
this shades the javaagent module classes themselves
There was a problem hiding this comment.
Rename it to shadedModule then? Or something similar. We don't shade muzzle here, do we?
mateuszrzeszutek
approved these changes
Dec 6, 2021
iNikem
approved these changes
Dec 6, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…pen-telemetry#4797) * Run muzzle check against bridge * Simplify * Renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #3044
This PR changes muzzle checks to run against shaded artifacts (similar to how tests are run against shaded artifacts). The main reason for doing this is to enable running muzzle checks against OpenTelemetry API instrumentation.
This will help unblock PR #4786 which is currently failing on
:instrumentation:reactor-3.1:javaagent:muzzledue tojava.lang.ClassNotFoundException: application.io.opentelemetry.context.ContextStorage