Remove url from HttpServerAttributesExtractor #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (publicAddress == null) { | ||
| return null; | ||
| } | ||
| return publicAddress.builder().build().getScheme(); |
There was a problem hiding this comment.
Can we use
Suggested change
| return publicAddress.builder().build().getScheme(); | |
| return publicAddress.get().getScheme(); |
instead of building another copy?
trask
force-pushed
the
remove-url-from-http-server-attributes-extractor
branch
from
e40881f
to
13da1a2
Compare
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Sep 29, 2021
| @@ -120,7 +115,6 @@ void normal() { | |||
| assertThat(attributes.build()) | |||
| .containsOnly( | |||
| entry(SemanticAttributes.HTTP_METHOD, "POST"), | |||
| entry(SemanticAttributes.HTTP_URL, "http:https://github.com"), | |||
| entry(SemanticAttributes.HTTP_TARGET, "github.com"), | |||
There was a problem hiding this comment.
I suspect I fudged - this test case should probably be changed to something that looks more normal, e.g. /repositories/1
| @Nullable | ||
| protected String host(Request request) { | ||
| return null; | ||
| URI uri = publicAddress.get(); |
There was a problem hiding this comment.
Private method to get the public address (the simplification I was hoping for with my TODO didn't materialize...
iNikem
reviewed
Sep 29, 2021
docs/semantic-conventions.md
Outdated
Comment on lines
26
to
27
| **[1]:** Most server instrumentation captures `http.scheme`, `http.host`, and `http.target` | ||
| (and does not capture `http.url`). |
There was a problem hiding this comment.
Suggested change
| **[1]:** Most server instrumentation captures `http.scheme`, `http.host`, and `http.target` | |
| (and does not capture `http.url`). | |
| **[1]:** Most server instrumentations capture `http.scheme`, `http.host`, and `http.target` | |
| (and do not capture `http.url`). |
There was a problem hiding this comment.
I went back and forth on this 😂
…p-server-attributes-extractor
mateuszrzeszutek
approved these changes
Sep 30, 2021
iNikem
approved these changes
Sep 30, 2021
…p-server-attributes-extractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #4195
resolves #3700
resolves #3699