-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary URL construction #3699
Labels
enhancement
New feature or request
Comments
I think the intent of the semantic conventions is to only return a URL if we have a URL, or otherwise return the parts, target, host, etc. Though not sure if this just makes it too confusing when writing instrumentation. |
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Constructing URL objects is a bit costly (in addition to memory, it does a lot of validation), and we construct them in various http server and http client instrumentations, generally in order to populate
http.url
attribute. This could probably be optimized by adding some kind of "uri builder" to our api that can be used instead.The text was updated successfully, but these errors were encountered: