Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[overhead] Append and update results (redux) #4038

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[overhead] Append and update results (redux) #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/nightly-benchmark-overhead.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,19 @@ jobs:
path: gh-pages
- name: copy results from gh-pages branch
run: |
rsync -avv gh-pages/benchmark-overhead/results/ benchmark-overhead/results/ && rm -rf gh-pages
rsync -avv gh-pages/benchmark-overhead/results/ benchmark-overhead/results/
- name: run tests
working-directory: benchmark-overhead
run: ./gradlew test
- name: inspect the results dir
working-directory: benchmark-overhead
run: ls -lR results
Comment on lines +25 to +27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary debugging, or helpful to keep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not both? :). I can remove it if you think it's too much clutter.

- name: copy results back to gh-pages branch
run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the rm -rf part needed? (not that it's hurting..)

Suggested change
run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results
run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely encountered problems with some of the GH actions when you have local changes. Some of them try and change branches and can't because of untracked changes. Removing the results like this helps to avoid those conditions. I'm hesitant to remove it...all the stars have to be aligned for it to work. ⭐ 😁

- name: commit updated results
uses: stefanzweifel/git-auto-commit-action@v4
uses: EndBug/add-and-commit@v7
with:
branch: gh-pages
commit_message: update test result data
file_pattern: benchmark-overhead/results
add: 'benchmark-overhead/results'
cwd: './gh-pages'
branch: 'gh-pages'
message: 'update test result data'
1 change: 0 additions & 1 deletion benchmark-overhead/results/README.md
View file
Open in desktop

This file was deleted.