[overhead] Append and update results (redux) #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Sep 1, 2021
Comment on lines
+25
to
+27
| - name: inspect the results dir | ||
| working-directory: benchmark-overhead | ||
| run: ls -lR results |
There was a problem hiding this comment.
temporary debugging, or helpful to keep?
There was a problem hiding this comment.
Why not both? :). I can remove it if you think it's too much clutter.
| working-directory: benchmark-overhead | ||
| run: ls -lR results | ||
| - name: copy results back to gh-pages branch | ||
| run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results |
There was a problem hiding this comment.
is the rm -rf part needed? (not that it's hurting..)
Suggested change
| run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results | |
| run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ |
There was a problem hiding this comment.
I have absolutely encountered problems with some of the GH actions when you have local changes. Some of them try and change branches and can't because of untracked changes. Removing the results like this helps to avoid those conditions. I'm hesitant to remove it...all the stars have to be aligned for it to work. ⭐ 😁
mateuszrzeszutek
approved these changes
Sep 1, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
stefanzweifel/git-auto-commit-actiontoEndBug/add-and-commit(it's more of what we need and is less targeted at static site generation). We leverage the gh-branch as a cloned subdir, copy the results into a local dir that is appended to by the test run. After the tests finish, we rsync the dir back into the subdir and remove the local copy.Tested multiple times in another repo and seems to work fine -- we can append the gh-pages this way without needing to commit back to main. 🤞🏻 🍀 🐰 🦶🏻