Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture the SNS topic ARN under the 'messaging.destination.name' span attribute. #10096

Merged
merged 10 commits into from
Jan 3, 2024
Merged

Capture the SNS topic ARN under the 'messaging.destination.name' span attribute. #10096

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3a7ad51
Record the TopicArn of an SNS Publish request under the 'messaging.de…
tduncan Dec 18, 2023
37a341a
Capture the SNS topic ARN within the AWS SDK v1 instrumentation.
tduncan Dec 21, 2023
5c9c14c
Format multi-line list assignment into one line per item.
tduncan Dec 21, 2023
db7ec8d
Capture the SNS target ARN as the messaging.destination.name attribut…
tduncan Dec 21, 2023
c221fbe
Fix spotless check errors.
tduncan Dec 21, 2023
b32078c
Add missing assertions to javaagent SNS tests.
tduncan Dec 22, 2023
62cc322
Add missing assertions to javaagent S3 tests.
tduncan Dec 22, 2023
9a6ce1c
Use internalSet from AttributesExtractorUtil in AWS SDK v1 SnsAttribu…
tduncan Dec 22, 2023
943a4a9
Add comment explaining that only one of TopicArn and TargetArn will b…
tduncan Dec 22, 2023
776adb4
Fix formatting.
tduncan Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment explaining that only one of TopicArn and TargetArn will b… 
…e set on an AWS SDK v2 request.
  • Loading branch information
@tduncan
tduncan committed Dec 22, 2023
commit 943a4a9e795f6fe6ff6acfa3cf341de989deb69b
3 changes: 3 additions & 0 deletions ...library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRequestType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ enum AwsSdkRequestType {
KINESIS(request("aws.stream.name", "StreamName")),
DYNAMODB(request("aws.table.name", "TableName")),
SNS(
/*
* Only one of TopicArn and TargetArn are permitted on an SNS request.
*/
request(SemanticAttributes.MESSAGING_DESTINATION_NAME.getKey(), "TargetArn"),
laurit marked this conversation as resolved.
Show resolved Hide resolved
request(SemanticAttributes.MESSAGING_DESTINATION_NAME.getKey(), "TopicArn"));

Expand Down