Capture the SNS topic ARN under the 'messaging.destination.name' span attribute.

[tduncan]

Addresses #10030

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tduncan / name: Thomas Duncan (3a7ad51, 37a341a, 5c9c14c, db7ec8d, c221fbe, b32078c, 62cc322, 9a6ce1c, 943a4a9, 776adb4)

[laurit]

Should the same change also be made for aws 1 instrumentation? Ideally I think we should change the SNS spans to follow messaging semantic conventions like we did for SQS, though this is probably too much effort and out of scope for this issue.

[tduncan]

@laurit, I'd be happy to update the AWS SDK v1 instrumentation as well though I don't see explicit support for SNS as I do in the v2 instrumentation.

[laurit]

@tduncan I think in aws1 sdk you'd need to add an accessor in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/RequestAccess.java that lets you reflectively retrieve the value and create an attribute extractor similar to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkExperimentalAttributesExtractor.java Can't use AwsSdkExperimentalAttributesExtractor because experimental (non spec) attributes are collected only when enabled with a flag. And add that extractor to

opentelemetry-java-instrumentation/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkInstrumenterFactory.java

Line 44 in 2199cc5

defaultAttributesExtractors = Arrays.asList(httpAttributesExtractor, rpcAttributesExtractor);

and

opentelemetry-java-instrumentation/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkInstrumenterFactory.java

Line 48 in 2199cc5

httpAttributesExtractor, rpcAttributesExtractor, experimentalAttributesExtractor);

Hopefully that would be enough (besides aws1 tests also run camel-2.20 tests, these also rely on the aws1 instrumentation)

[tduncan]

@laurit, thanks for the tips! I'll explore the v1 SDK instrumentation in more detail.

[laurit]

Usually we use

opentelemetry-java-instrumentation/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/AttributesExtractorUtil.java

Lines 22 to 27 in 1ee51e4

	public static <T> void internalSet(
	AttributesBuilder attributes, AttributeKey<T> key, @Nullable T value) {
	if (value != null) {
	attributes.put(key, value);
	}
	}

which does the null check