Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add semantic conventions for specification v1.17.0 #7171

Merged
merged 1 commit into from
Feb 15, 2023
Merged

add semantic conventions for specification v1.17.0 #7171

merged 1 commit into from
Feb 15, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Feb 9, 2023 •
edited
Loading

Link to tracking Issue:

Closes #7170

@frzifus frzifus requested a review from a team as a code owner February 9, 2023 15:32
@Aneurysm9
Copy link
Member

Can you make a similar change to open-telemetry/opentelemetry-go#3697? There's a new type of convention to generate.

@frzifus
Copy link
Member Author

frzifus commented Feb 9, 2023

yes 👍

@frzifus frzifus force-pushed the semconv_v1.17.0 branch 2 times, most recently from 6d1806d to edc1844 Compare February 9, 2023 16:38
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 90.84% // Head: 90.99% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (fe1cffd) compared to base (e2a6cd7).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7171      +/-   ##
==========================================
+ Coverage   90.84%   90.99%   +0.14%     
==========================================
  Files         293      293              
  Lines       14302    14271      -31     
==========================================
- Hits        12993    12986       -7     
+ Misses       1041     1017      -24     
  Partials      268      268
Impacted Files Coverage Δ
pdata/plog/logs.go 100.00% <0.00%> (ø)
pdata/ptrace/traces.go 100.00% <0.00%> (ø)
pdata/pmetric/metrics.go 100.00% <0.00%> (ø)
internal/cgroups/cgroups.go 92.00% <0.00%> (+0.21%) ⬆️
featuregate/registry.go 95.58% <0.00%> (+24.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bogdandrutu
bogdandrutu reviewed Feb 9, 2023
View reviewed changes
semconv/v1.17.0/nonstandard.go Outdated Show resolved Hide resolved
semconv/v1.17.0/nonstandard.go Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

Need to adapt the tests.

@frzifus
Copy link
Member Author

frzifus commented Feb 10, 2023

I will try to have a look in the coming hours.

frzifus
frzifus commented Feb 13, 2023
View reviewed changes
semconv/semconv_test.go Outdated

end := len(expectedFiles)
switch f.Name() {
case "v1.17.0": // no nonstandard.go file requiered.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might not be the ideal solution. But I thought a versions comparison with e.g. github.com/hashicorp/go-version would be an overkill. Alternatively we could just add a file without extra constants.

whats your thoughts on it?

@bogdandrutu bogdandrutu merged commit b04c8d9 into open-telemetry:main Feb 15, 2023
@frzifus frzifus deleted the semconv_v1.17.0 branch February 15, 2023 07:27
@frzifus frzifus mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add semantic conventions for specification v1.17.0
3 participants
@frzifus @Aneurysm9 @bogdandrutu