add semantic conventions for specification v1.18.0 #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need more work? |
frzifus
force-pushed
the
semconv_v1.18.0
branch
from
7ddec55
to
9bdd722
Compare
|
y, i did wait for #7171. Now its rdy to review @bogdandrutu |
Codecov ReportBase: 90.99% // Head: 90.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #7169 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 293 293
Lines 14271 14271
=======================================
Hits 12986 12986
Misses 1017 1017
Partials 268 268 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
semconv_v1.18.0
branch
from
9bdd722
to
eab7e15
Compare
bogdandrutu
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important (read before submitting)
We are currently preparing for the upcoming 1.0 GA release. Pull requests that are not aligned with
the current roadmap https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/roadmap.md
and are not aimed at stabilizing and preparing the Collector for the release will not be accepted.
Delete this paragraph before submitting.
Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Link to tracking Issue:
Closes #7168
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>
Please delete paragraphs that you did not use before submitting.