Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename NewParser* -> NewConfigMap* #4032

Merged
merged 1 commit into from
Sep 14, 2021
Merged

rename NewParser* -> NewConfigMap* #4032

merged 1 commit into from
Sep 14, 2021

Conversation

codeboten
Copy link
Contributor

Description:
Clean up constructors for ConfigMap which were left after the rename from Parser

Link to tracking Issue: Fix #4026

@codeboten codeboten requested review from a team and tigrannajaryan September 13, 2021 17:40
@codeboten codeboten mentioned this pull request Sep 13, 2021
Merged
@bogdandrutu bogdandrutu merged commit 2598791 into open-telemetry:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent constructor funcs for ConfigMap
2 participants
@codeboten @bogdandrutu