rename NewParser* -> NewConfigMap* #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs an update for the collector. |
codeboten
requested review from
alolita,
Aneurysm9,
anuraaga,
arminru,
djaglowski,
dmitryax,
jmacd,
jpkrohling,
jsuereth,
kbrockhoff,
mx-psi,
owais,
punya and
a team
as code owners
codeboten
force-pushed
the
codeboten/fix-parser
branch
from
dca14a5
to
189b93e
Compare
|
@codeboten build fails |
codeboten
force-pushed
the
codeboten/fix-parser
branch
from
189b93e
to
eb78e06
Compare
|
I re-ran |
mx-psi
approved these changes
Sep 15, 2021
|
Ah i see whats happening now. The tests are failing because of this issue open-telemetry/opentelemetry-collector#4043 |
codeboten
force-pushed
the
codeboten/fix-parser
branch
from
eb78e06
to
dc4320b
Compare
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
- Move `model/semconv` package to a new `semconv` module - Add deprecation notices to API from `model/semconv`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to core pr: open-telemetry/opentelemetry-collector#4032