Remove unnecessary Session, one per ConfigSource anyway #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
LGTM.
Just for the benefit if someone reaches this PR later: initial idea was to create the config source for the life of the collector in that context it appeared to have value to separate the config source from the session. In practice, the separation provided little benefit especially with the manager creating the config sources each time the configuration was reloaded.
dashpole
approved these changes
Aug 10, 2021
carlosalberto
approved these changes
Aug 11, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR makes the ConfigSource equivalent with the Session, and relies on the fact that when created ConfigSource does what NewSession was doing. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ConfigSource equivalent with the Session, and
relies on the fact that when created ConfigSource does what
NewSession was doing.
Depends on #3792