Make configsource Watchable an optional interface #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
optconfigsource
branch
from
685ea29
to
34233e1
Compare
dmitryax
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Aug 18, 2021
Adapt code to changes in core: - config.experimental.configsource.Watchable interface open-telemetry/opentelemetry-collector#3792 - Rename CustomUnmarshable to Unmarshallable open-telemetry/opentelemetry-collector#3774 - Switched metrics from Value() to DoubleVal() open-telemetry/opentelemetry-collector#3740
emaderer
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Aug 18, 2021
* Bump smart agent version to v5.11.3 * Update CHANGELOG.md * Update core/contrib deps * Fix broken code due to renaming of CustomUnmarshable to Unmarshallable * Fix broken code due to renaming of CustomUnmarshable to Unmarshallable * Revert "Fix broken code due to renaming of CustomUnmarshable to Unmarshallable" This reverts commit de03f5e. * Revert "Fix broken code due to renaming of CustomUnmarshable to Unmarshallable" This reverts commit e09a9e3. * Update code according to changes in core Adapt code to changes in core: - config.experimental.configsource.Watchable interface open-telemetry/opentelemetry-collector#3792 - Rename CustomUnmarshable to Unmarshallable open-telemetry/opentelemetry-collector#3774 - Switched metrics from Value() to DoubleVal() open-telemetry/opentelemetry-collector#3740 Co-authored-by: Eyal Maderer <[email protected]> Co-authored-by: Dmitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]