Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Decouple Config structs from internal components #8375

Merged
merged 4 commits into from
Mar 18, 2022
Merged

[exporter/datadog] Decouple Config structs from internal components #8375

merged 4 commits into from
Mar 18, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 10, 2022 •
edited
Loading

Description:

Decouple config.Config and related structs from internal components. In particular:

  • Remove reference to Config on GetHost
  • Remove reference to Config on ProcessMetrics
  • Decouple metadata pusher configuration from main configuration

This is so that we can move config to the main package while avoiding cycles.

This is an internal refactor with no public changes.

Link to tracking Issue: #8373

Testing:

  • amended unit tests.
  • end to end testing of host metadata.
  • check that the fallback hostname on the configuration is picked up.

@project-bot project-bot bot added this to In progress in Collector Mar 10, 2022
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 10, 2022
@mx-psi mx-psi force-pushed the mx-psi/refactor-host-metadata branch from c69e095 to f14ad29 Compare March 10, 2022 14:19
@mx-psi mx-psi force-pushed the mx-psi/refactor-host-metadata branch from f14ad29 to ee8b160 Compare March 10, 2022 14:45
@mx-psi mx-psi marked this pull request as ready for review March 10, 2022 15:53
@mx-psi mx-psi requested a review from a team as a code owner March 10, 2022 15:53
@mx-psi mx-psi requested a review from bogdandrutu March 10, 2022 15:53
KSerrania
KSerrania approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PusherConfig objects being abbreviated mcfg is slightly confusing, but otherwise LGTM.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 15, 2022

The PusherConfig objects being abbreviated mcfg is slightly confusing, but otherwise LGTM.

I changed that, originally I named it MetadataPusherConfig, but the linters don't like that 😄

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Mar 18, 2022
@mx-psi
Copy link
Member Author

mx-psi commented Mar 18, 2022

Marking as ready-to-merge since it has a codeowner approval

Collector automation moved this from In progress to Reviewer approved Mar 18, 2022
@jpkrohling jpkrohling merged commit 6283915 into open-telemetry:main Mar 18, 2022
foxlegend pushed a commit to foxlegend/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2022
@mx-psi
[exporter/datadog] Decouple Config structs from internal components (…
f0510cb 
…open-telemetry#8375)

* [exporter/datadog] Remove reference to `Config` on `GetHost`

* [exporter/datadog] Remove reference to Config on ProcessMetrics

* [exporter/datadog] Decouple metadata pusher configuration from main configuration

* `fd -e go --base-directory exporter/datadogexporter -X sd mcfg pcfg`
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@KSerrania KSerrania KSerrania approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@djaglowski djaglowski

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mx-psi @jpkrohling @KSerrania @djaglowski