-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Move Config
structs to main package and reduce API
#8373
Labels
exporter/datadog
Datadog components
Comments
8 tasks
This was referenced Mar 10, 2022
This was referenced Mar 17, 2022
This was referenced Mar 30, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What will change?
The
Config
structs will be moved to the main package, and will only haveUnmarshal
andValidate
as public methods. In particular:OnceMetadata
method will be removed fromConfig
,GetHostTags
method will be removed fromTagsConfig
.GetCensoredKey
method will be removed fromAPIConfig
.Sanitize
method will be removed fromConfig
, and its functionality will be put intoValidate
andSanitize
.Additionally, enum-based configuration settings will use the enum value instead of a
string
.Who is affected?
Only users of the Go API will be affected. End-users of the binaries won't be affected.
What should I do if I am affected?
These functions and structs are used internally by the Datadog exporter and the OpenTelemetry Collector, but we don't expect external users to be using them (at least for now!). If you are using them, please reach out.
When will it change?
Versions in italics are tentative
OnceMetadata
methodGetCensoredKeys
methodGetHostTags
methodSanitize
methodConfig
structs to main packageThe text was updated successfully, but these errors were encountered: