Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint timeout to avoid build failures #7237

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jan 17, 2022

Currently particular runs of golangci-lint can take up to 15 minutes causing CI build failures. This change bumps the limit to avoid the build failures. The root cause of the issue #7183 is still to be resolved.

Currently particular runs of githubci-lint can take up to 15 minutes causing CI build failures
@dmitryax dmitryax requested a review from a team as a code owner January 17, 2022 23:20
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 17, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes... that's a long time to run lint :(

@dmitryax
Copy link
Member Author

dmitryax commented Jan 18, 2022

Yeah, this time cannot be right, we need to do something with it. This PR is just a short-term mitigation measure

@codeboten codeboten merged commit add40a5 into open-telemetry:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants