Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running golangci-lint on ./cmd/configschema takes up to 10 minutes in make golint #7183

Closed
dmitryax opened this issue Jan 17, 2022 · 5 comments
Closed

Running golangci-lint on ./cmd/configschema takes up to 10 minutes in make golint #7183

dmitryax opened this issue Jan 17, 2022 · 5 comments
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues closed as inactive help wanted Extra attention is needed Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 17, 2022 •
edited
Loading

Running make -C ./cmd/configschema lint in build-and-lint / lint GH Actions job usually takes 8-10 minutes . Sometimes golangci-lint goes above 10 minutes limit causing CI job to fail. Failed jobs examples:

Looks like running golangci-lint run concurrently blocks other parallel makefile jobs. ./cmd/configschema is always affected as the first module in the list.
@dmitryax dmitryax added the bug Something isn't working label Jan 17, 2022
@dmitryax dmitryax mentioned this issue Jan 17, 2022
Closed
@dmitryax dmitryax changed the title Running make -C ./cmd/configschema lint takes up to 10 minutes Running golangci-lint on ./cmd/configschema takes up to 10 minutes in make golint Jan 17, 2022
This was referenced Jan 17, 2022
Closed
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2023
@dmitryax dmitryax reopened this Apr 18, 2023
@dmitryax dmitryax added bug Something isn't working help wanted Extra attention is needed ci-cd CI, CD, testing, build issues and removed Stale closed as inactive bug Something isn't working labels Apr 18, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@dmitryax dmitryax removed the Stale label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Oct 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues closed as inactive help wanted Extra attention is needed Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable golangci concurrency dmitryax/opentelemetry-collector-contrib
1 participant
@dmitryax