Added CollectD JSON receiver #44
Conversation
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
| "github.com/golang/protobuf/ptypes/timestamp" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
|
|
receiver/collectdreceiver/factory.go
Outdated
| "time" | ||
|
|
||
| "go.uber.org/zap" | ||
|
|
owais
force-pushed
the
collectdreceiver
branch
2 times, most recently
from
e19315f
to
a01f119
Compare
owais
force-pushed
the
collectdreceiver
branch
2 times, most recently
from
fb26eb4
to
6e004fa
Compare
|
This is really a receiver for the collectd write_http plugin with the Also this is a super-set of the protocol that supports arbitrary dimensions via the square bracket, comma separated key value pairs appended to various fields of the value, which should also be clarified in the doc for this receiver as it is technically not fully backwards compatible with the original protocol since you could legally have square brackets in the value fields that could result in unintended conversions for people that weren't using the SignalFx-specific form of collectd. |
owais
force-pushed
the
collectdreceiver
branch
2 times, most recently
from
1e954d0
to
dc833e8
Compare
|
Updated. @pjanotti please take a look as well when you can. |
owais
force-pushed
the
collectdreceiver
branch
from
dc833e8
to
ed54918
Compare
| lKeys, lValues := labelKeysAndValues(labels) | ||
| metric.MetricDescriptor = &metricspb.MetricDescriptor{ | ||
| Name: name, | ||
| Type: r.metricType(dsType, isDouble), |
There was a problem hiding this comment.
Comment: this bothers me on the proto: the point has the value but the metric descriptor too... so the format itself allow inconsistencies... am I missing something?
There was a problem hiding this comment.
It does. In the sense that descriptor can say the metric is let's say commulative double but each point can be then be either int or double.
There was a problem hiding this comment.
@tigrannajaryan was the above improved in OTel metrics?
There was a problem hiding this comment.
No, not improved. Otel metrics still has a type enum in the decsriptor and then a set of fields to store data points. It is possible to misuse it the same way we have here.
There was a problem hiding this comment.
Is it worth opening an issue on spec repo? Or there are reasons for that?
owais
force-pushed
the
collectdreceiver
branch
4 times, most recently
from
978a2b3
to
c6389c4
Compare
|
Thanks for the detailed review @pjanotti. Updated the PR. |
| lKeys, lValues := labelKeysAndValues(labels) | ||
| metric.MetricDescriptor = &metricspb.MetricDescriptor{ | ||
| Name: name, | ||
| Type: r.metricType(dsType, isDouble), |
There was a problem hiding this comment.
@tigrannajaryan was the above improved in OTel metrics?
owais
force-pushed
the
collectdreceiver
branch
from
c6389c4
to
d9ab2f2
Compare
Ported SignalFx CollectD receiver from SignalFX Gateway to OpenTelemetry Collector Ported from: https://github.com/signalfx/gateway/tree/master/protocol/collectd
owais
force-pushed
the
collectdreceiver
branch
from
d9ab2f2
to
08bdbd0
Compare
[Closes #43]
The files removed in this change already have instrumentation in the opentelemetry-python repo. Removing them from this reference folder as they're no longer needed.
…pen-telemetry#44) * Modify resourcedetection processor to use our aws-cwa-dev confighttp
Ported CollectD receiver from SignalFX Gateway to OpenTelemetry Collector
Ported from: https://github.com/signalfx/gateway/tree/master/protocol/collectd